-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
마지막 #16
base: jaehyeon
Are you sure you want to change the base?
마지막 #16
Conversation
public static FundingArticleDto fromEntity(FundingArticle fundingArticle) { | ||
return new FundingArticleDto( | ||
fundingArticle.getAuthor().getNickname(), | ||
DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss").format(fundingArticle.getAuthor().getBirthdate()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LocalDateTime그대로 보내고 JsonFormat 해봐도 좋을듯
this.endAt = this.endAt.plusDays(maxExtensionDate); | ||
} | ||
|
||
public void updateStatus(EFundingArticleStatus status) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 setter사용인데 괜찮나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
인정합니다
@Builder | ||
private FundingArticleGifticon(Gifticon gifticon, FundingArticle fundingArticle) { | ||
this.gifticon = gifticon; | ||
this.fundingArticle = fundingArticle; | ||
} | ||
|
||
public void updateStatus(EFundingArticleGifticonStatus eFundingArticleGifticonStatus) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거도 setter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
인정합니다
Pageable pageable); | ||
|
||
@EntityGraph(attributePaths = {"author", "gifticons"}) | ||
Optional<FundingArticle> findAllWithAuthorAndGifticonsById(Long articleId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
잘 배웠습니다
interface FundingContributerNumber { | ||
Long getFundingArticleGifticonId(); | ||
Integer getContributerNumber(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bb
.toList()) | ||
.build(); | ||
} | ||
throw new CustomApiException("depth는 1또는 2만 가능합니다."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
early return 하는거도 좋을듯
많이 못해서 죄송합니다